New hash-based ABI

chrisethchriseth Member Posts: 170 ✭✭✭
Just a quick note: The ABI has changed with regards to padding and the way functions are selected:


  • jpritikinjpritikin Member Posts: 29
    Chris, why isn't the function's return value/s part of the function hash? C/C++ has always omitted the return type from the function signature, but it might be worth revising this design decision.
  • jpritikinjpritikin Member Posts: 29
    Another thought is versioning. There are likely to evolve many versions of the same API. It may make things easier for developers if the function hash included a version number. The version number would be the same for all functions declared in the same namespace. This version number could be appended to the function signature.
  • JasperJasper Eindhoven, the NetherlandsMember Posts: 514 ✭✭✭
    Since you apparently have a uint8 why not represent bool with that? Infact, wonder if N%8==0 isnt somewhat arbitrary given how the EVM works, now people might still end up taking uint8s and stripping them for 8 bools manually. Note that uint40 goes with that scheme..

    I did notice that, as-is, the first and last bits of a slot are cheapest to select; x%2**N and x/2**(256-N) as compared to the middle L; (x/2**N)%2**L Of course, if you add opcodes to chop slots up, the byte-sized approach is faster.

    Also you never set calldataload you do set memory/storage slots. Probably only want to chop storage slots up, though. Still, to set on you then first need the access the existing one, strip the bit you do not want to set.. Costs there too.[i] = ([i]/2**N)*2**N + value_N_bits at the beginning, in the middle:[i] = ([i]/2**(N+L))*2**(N) +[i]%2**N + value_N_bits

    Tbh though, seems to me just op-code-for-selecting-bytes/set-selected-bytes is the way to go, unless i am missing something. Can forget this whole story then.
  • chrisethchriseth Member Posts: 170 ✭✭✭
    I am not sure I understand the direction you want to go, but it might be that the MSTORE8 / MLOAD8 opcodes are what you are looking for.

    Please start a new thread for such general discussions or come to #ethereum-dev on freenode (most people are there during CET afternoons).
  • JasperJasper Eindhoven, the NetherlandsMember Posts: 514 ✭✭✭
    The point of languages like Solidity is to not deal with the opcodes directly? I and Solidity devs already know about them.
Sign In or Register to comment.